Infectious disease modelling team | UKHSA
statistics PhD, education, & consultancy
data scientist & infectious disease modeller
bit of git nerd
I mostly work in R, concepts are language-agnostic
🎓 a big chunk of my team have an academic background
👩💻 we spend a lot of time developing software …
📊 … but we’re in analytical roles
🤫 honestly? This talk is for me …
vote with 👍 and 👎 emojis
📝 write some comments
💻 run the code
🔧 make direct suggestions
👀 let’s review some code
✔️ quality & compliance
💡 provide ideas for improving the code
🧠 knowledge transfer
🚌 increase your bus number!
🐛 potential bugs
📈 quality of outputs
🔢 check the mathematics and statistics
💼 sensitive information!
❤️ be kind and praise your team members
☕ take a break if you’re getting grumpy
❓ ask open ended questions about the code
🤖 automate the painful stuff: linters, stylers, CI/CD
🩺 accept PRs when overall health is improved
☎️ have a natter about the code
🛠️ favour maintainable and readable code
👪 broaden the discussion
🕷️ Nit: this is minor; I am being pedantic
🤔 Consider: I’m not too bothered, would be nice
🤷 FYI: out of scope, I think you’d like this approach
⚠️ Should: an essential fix!
📰 come up with your own team code review style
📣 agree on the style as a team activity
♻️ trial it, review it, adapt it
🖊️ document your process (use a wiki!)
🤔 come up with a sensible approach
🖊️ document it, shout about it, adapt it
🎯 apply the rules consistently
🤷 anything else is just an opinion
⛵ we run a tight ship
😩 decision fatigue
💎 clarity leads to productivity
🤷 maybe they should be called standard practices
🔑 code review is key to quality outputs
👪 we all need to be reviewing code
👏 be kind, supportive and encouraging
⏩ keep code moving forward
@_jcken@fossoton.org
Connect with me!
Chat on Gov DS
Maybe see you at a north-east tech meetup?
well done for getting this far …